Skip to content

[WIP] Flamelet approach for premixed flames#1826

Closed
bigfooted wants to merge 121 commits intodevelopfrom
feature_new_flamelet
Closed

[WIP] Flamelet approach for premixed flames#1826
bigfooted wants to merge 121 commits intodevelopfrom
feature_new_flamelet

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Nov 22, 2022 •
edited
Loading

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
This PR introduces a tabulated chemistry approach. The focus for this PR is on laminar and premixed flames in the incompressible framework, but it is generalizable to non-premixed and partially premixed flames, turbulent flames and compressible flames.
In this approach, 2 transport equations are solved for progress variable and total enthalpy. The lookup table retrieves quantities (temperature, density, viscosity, diffusivity, source terms, etc) as a function of these independent control variables. 2 additional independent transport equations are solved for the species NO and CO.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

Nijso Checklist

  • Replace bloated initialization (burnt and unburnt region) with python wrapper
  • Check Conjugate Heat Transfer
  • Check adjoint optimization workflow
  • Check axisymmetric setup
  • Check diffusivity
  • Check primal restart
  • Check adjoint restart
  • Adjoint comparison with FD

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

nbe0dev and others added 30 commits August 30, 2022 21:58
initial commit for new flamelet implementation
485165c
@bigfooted
added laminar flamelet implementation, turbulence not working yet
badf333
@bigfooted
Merge branch 'develop' into feature_new_flamelet
a5cb511
@bigfooted
addedfix class override bug
ac1e866
@bigfooted
added csourcepiecewise class and fixed segfault with this
b403a54
@bigfooted
fixed isothermal wall due to missing initialization of Res_TruncError
0c87a28
@bigfooted
fixed isfix get-triangle bug
1e335fd
@bigfooted
fixed diffusivity model, primal is running again
e2b5de8
@bigfooted
removed some commented stuff
9dd1d66
@bigfooted
trying to make temperature a passive field
04e1da8
@bigfooted
Merge branch 'develop' into feature_new_flamelet
0917464
@bigfooted
fixed convergence issues, primal runs fine
a1843f6
@bigfooted
fixed conveenergy equation is switched off when flamelets active
bc6cddf
@bigfooted
merge with develop
2167083
@bigfooted
fix primal restart
e2155c3
@bigfooted
added lookup variables
d0f5886
@bigfooted
added auxiliary species transport (primal)
639df8a
@bigfooted
fix axisymmetry, trapezoidalmap
8344c1c
@bigfooted
fix viscosity ptr bug, fix turb+flamelet bug, fix target massflow com…
de881fb 
…putation inconsistency
@bigfooted
Merge branch 'develop' into feature_new_flamelet
80ddee5
@bigfooted
fix viscosity ptremove cout
9409c17
@danielmayer
932b0e3 
Update LUT reader to version 1.0.1
@danielmayer
0366c44 
Add laminar premixed flame regression test.
@bigfooted
merge with develop, fix conflicts with species solver
27d0780
@bigfooted
remove spaces, empty lines and bool flagEnergy
9da7222
@bigfooted
fix bug in trapezoidalmap, update lut format
88c501b
@bigfooted
remove unused variable
f1990a7
@bigfooted
update capitalization of LUT header file
66c90c2
@bigfooted
remove commented includes
13de58b
@bigfooted
replace line stripping with inline function
68327d6
bigfooted and others added 14 commits January 16, 2023 20:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2023
View reviewed changes
Common/src/CConfig.cpp
}
checkScalarBounds(Species_Init_Sum, "SPECIES_INIT sum", 0.0, 1.0);

for (unsigned short iMarker = 0; iMarker < nMarker_Inlet_Species; iMarker++) {

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable iMarker hides another variable of the same name (on [line 3387](1)).
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2023
View reviewed changes
@bigfooted
Copy link
Contributor Author

bigfooted commented Feb 3, 2023 •
edited
Loading

discadj_arina2k fails with some mpi error, but it does not fail when I run it on my local machine. Not sure what is going on here.

Clearing the computational graph.
[9c7d9f63f200:01637] *** An error occurred in MPI_Allgather
[9c7d9f63f200:01637] *** reported by process [4177330177,1]
[9c7d9f63f200:01637] *** on communicator MPI_COMM_WORLD
[9c7d9f63f200:01637] *** MPI_ERR_TRUNCATE: message truncated
[9c7d9f63f200:01637] *** MPI_ERRORS_ARE_FATAL (processes in this communicator will now abort,
[9c7d9f63f200:01637] ***    and potentially your MPI job)

There is another case that sometimes fails due to the tight tolerance.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2023
View reviewed changes
SU2_CFD/include/numerics/species/species_diffusion.hpp
using Base::Jacobian_j;

const bool turbulence;
//const bool flamelet;

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
danielmayer
danielmayer reviewed Feb 7, 2023
View reviewed changes
SU2_CFD/src/fluid/CFluidFlamelet.cpp
table_source_names.resize(n_table_sources);
table_sources.resize(n_table_sources);
table_source_names[I_SRC_TOT_PROGVAR] = "ProdRateTot_PV";
table_source_names[I_SRC_TOT_PROGVAR] = "ProdRateTot-PV";
Copy link
Contributor

@danielmayer danielmayer Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to call it ProdRateTot_PV in the latest dragon format. The logic is _ and inside we can use "-" to separate words. Also, e.g.: ProdRatePos_Y-CO. I know this is an inconvenience
for existing dragon tables with the other nomenclature. My proposal is to rename this in your existing tables now for the last time and in the future we will handle changes to the hard coded variable names through version numbers of the dragon file. Hope that works for everybody. Please let me know.

@bigfooted bigfooted closed this Feb 7, 2023
@bigfooted bigfooted reopened this Feb 7, 2023
@bigfooted bigfooted closed this Feb 7, 2023
@bigfooted
Copy link
Contributor Author

bigfooted commented Feb 7, 2023

I will close this pull request every time Evert commits something.

@EvertBunschoten EvertBunschoten mentioned this pull request Jan 9, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielmayer danielmayer danielmayer left review comments

@Cristopher-Morales Cristopher-Morales Cristopher-Morales left review comments

@EvertBunschoten EvertBunschoten EvertBunschoten approved these changes

Assignees

No one assigned

Labels

changelog:feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bigfooted @pcarruscag @EvertBunschoten @danielmayer @Cristopher-Morales